Switch to esbuild #388
Merged
Switch to esbuild #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfcampbell
added
the
Type: Maintenance
wolfy1339
reviewed
Jun 1, 2023
Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
wolfy1339
reviewed
Jun 1, 2023
wolfy1339
approved these changes
Jun 1, 2023
wolfy1339
requested changes
Jun 2, 2023
| @@ -106,6 +89,6 @@ | |||
| ] | |||
| }, | |||
| "engines": { | |||
| "node": ">= 14" | |||
| "node": ">= 18" | |||
There was a problem hiding this comment.
Suggested change
| "node": ">= 18" | |
| "node": ">= 14" |
| outdir: "pkg/dist-node", | ||
| bundle: true, | ||
| platform: "node", | ||
| target: "node18", |
There was a problem hiding this comment.
Suggested change
| target: "node18", | |
| target: "node14", |
|
🎉 This PR is included in version 2.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicating octokit/request.js#584 to another repo.
Pika has been deprecated for a while now, and the project has now been archived, and because of that the released npm package is missing most of the files generated by the build step.
Uses esbuild to transpile the TS source code into an ESM source, NodeJs bundle, and a browser bundle
Uses the TypeScript compiler to generate the types.
Behavior
Before the change?
dist-node,dist-types,dist-web... even though they are generated correctly.After the change?
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: Maintenance