Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "default" export in package.json #195

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Conversation

KyleBoyer
Copy link
Contributor

@KyleBoyer KyleBoyer commented Apr 23, 2024

Resolves #194


Before the change?

  • No "default" defined in package.json -> exports['.']

After the change?

  • "default" field appended to package.json -> exports['.']

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Related PRs

octokit/plugin-retry.js#542
octokit/plugin-throttling.js#695

Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

scripts/build.mjs Outdated Show resolved Hide resolved
@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Apr 23, 2024
@wolfy1339 wolfy1339 merged commit 2cab8e2 into octokit:main Apr 23, 2024
6 checks passed
Copy link

🎉 This PR is included in version 5.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: "default" export missing from package.json
2 participants