BREAKING CHANGE: remove node-fetch in favor of global

README.md

@@ -10,8 +10,7 @@ to interact with [GitHub’s REST API](https://developer.github.com/v3/) and
 [GitHub’s GraphQL API](https://developer.github.com/v4/guides/forming-calls/#the-graphql-endpoint).
 
 It uses [`@octokit/endpoint`](https://github.com/octokit/endpoint.js) to parse
-the passed options and sends the request using [fetch](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API)
-([node-fetch](https://github.com/bitinn/node-fetch) when the runtime has no native `fetch` API).
+the passed options and sends the request using [fetch](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API).
 
 <!-- update table of contents by running `npx markdown-toc README.md -i` -->
 
@@ -319,7 +318,7 @@ const { data: app } = await requestWithAuth(
       Function
     </td>
     <td>
-     Custom replacement for <a href="https://github.com/bitinn/node-fetch">built-in fetch method</a>. Useful for testing or request hooks.
+     Custom replacement for <a href="https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API">fetch</a>. Useful for testing or request hooks.
     </td>
   </tr>
   <tr>

package.json

@@ -26,7 +26,6 @@
     "@octokit/request-error": "^3.0.0",
     "@octokit/types": "^9.0.0",
     "is-plain-object": "^5.0.0",
-    "node-fetch": "^2.6.7",
     "universal-user-agent": "^6.0.0"
   },
   "devDependencies": {
@@ -44,6 +43,7 @@
     "fetch-mock": "^9.3.1",
     "jest": "^29.0.0",
     "lolex": "^6.0.0",
+    "node-fetch": "^2.6.7",
     "prettier": "2.8.8",
     "semantic-release-plugin-update-version-in-files": "^1.0.0",
     "string-to-arraybuffer": "^1.0.2",

src/fetch-wrapper.ts

@@ -1,5 +1,4 @@
 import { isPlainObject } from "is-plain-object";
-import nodeFetch, { HeadersInit, Response } from "node-fetch";
 import { RequestError } from "@octokit/request-error";
 import { EndpointInterface } from "@octokit/types";
 
@@ -26,10 +25,10 @@ export default function fetchWrapper(
   let status: number;
   let url: string;
 
-  const fetch: typeof nodeFetch =
-    (requestOptions.request && requestOptions.request.fetch) ||
-    globalThis.fetch ||
-    /* istanbul ignore next */ nodeFetch;
+  let { fetch } = globalThis;
+  if (requestOptions.request?.fetch) {
+    fetch = requestOptions.request.fetch;
+  }
 
   return fetch(
     requestOptions.url,

src/get-buffer-response.ts

@@ -1,4 +1,3 @@
-import { Response } from "node-fetch";
 export default function getBufferResponse(response: Response) {
   return response.arrayBuffer();
 }

test/request.test.ts

@@ -1,9 +1,13 @@
+if (parseInt(process.versions.node.split(".")[0]) < 18) {
+  const fetch = require("node-fetch");
+  globalThis.fetch = fetch;
+  globalThis.Headers = fetch.Headers;
+}
 import fs from "fs";
 import stream from "stream";
 
 import { getUserAgent } from "universal-user-agent";
 import fetchMock from "fetch-mock";
-import { Headers, RequestInit } from "node-fetch";
 import { createAppAuth } from "@octokit/auth-app";
 import lolex from "lolex";
 import {
@@ -447,7 +451,7 @@ x//0u+zd/R/QRUzLOw4N72/Hu+UG6MNt5iDZFCtapRaKt6OvSBwy8w==
   });
 
   it("passes node-fetch options to fetch only", () => {
-    const mock = (url: string, options: RequestInit) => {
+    const mock = (url: string, options: { timeout: number }) => {
       expect(url).toEqual("https://api.github.com/");
       expect(options.timeout).toEqual(100);
       return Promise.reject(new Error("ok"));
@@ -890,7 +894,7 @@ x//0u+zd/R/QRUzLOw4N72/Hu+UG6MNt5iDZFCtapRaKt6OvSBwy8w==
       });
     };
 
-    const mock = (url: string, options: RequestInit) => {
+    const mock = (url: string, options: { timeout: number }) => {
       expect(url).toEqual("https://api.github.com/");
       expect(options.timeout).toEqual(100);
       return delay().then(() => {