From dc56a0bedf081bcedf92fcc6eaa440a3d6dd0a56 Mon Sep 17 00:00:00 2001 From: Amir Blum Date: Sat, 23 Nov 2024 10:13:41 +0200 Subject: [PATCH] fix: set max_recv_msg_size_mib to value in correct units (#1826) The value in `max_recv_msg_size_mib` for otlp receiver in cluster collector config should be in alignment with the memory the deployment has to run. It was set accidentally to `128 * 1024 * 1024` (e.g. value in bytes), instead of intended `128` which is a reasonable number to use. before this change, the value being populated in the config would be `134217728` MiB which makes no sense --- common/config/root.go | 2 +- common/config/testdata/debugexporter.yaml | 2 +- common/config/testdata/minimal.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/common/config/root.go b/common/config/root.go index 57ecf1c69..adae1e3fc 100644 --- a/common/config/root.go +++ b/common/config/root.go @@ -149,7 +149,7 @@ func getBasicConfig(memoryLimiterConfig GenericMap) (*Config, []string) { "protocols": GenericMap{ "grpc": GenericMap{ // setting it to a large value to avoid dropping batches. - "max_recv_msg_size_mib": 128 * 1024 * 1024, + "max_recv_msg_size_mib": 128, "endpoint": "0.0.0.0:4317", }, // Node collectors send in gRPC, so this is probably not needed diff --git a/common/config/testdata/debugexporter.yaml b/common/config/testdata/debugexporter.yaml index 4090a8ebb..35d114505 100644 --- a/common/config/testdata/debugexporter.yaml +++ b/common/config/testdata/debugexporter.yaml @@ -3,7 +3,7 @@ receivers: protocols: grpc: endpoint: 0.0.0.0:4317 - max_recv_msg_size_mib: 134217728 + max_recv_msg_size_mib: 128 http: endpoint: 0.0.0.0:4318 exporters: diff --git a/common/config/testdata/minimal.yaml b/common/config/testdata/minimal.yaml index a15637882..925a48b47 100644 --- a/common/config/testdata/minimal.yaml +++ b/common/config/testdata/minimal.yaml @@ -3,7 +3,7 @@ receivers: protocols: grpc: endpoint: 0.0.0.0:4317 - max_recv_msg_size_mib: 134217728 + max_recv_msg_size_mib: 128 http: endpoint: 0.0.0.0:4318 exporters: {}