Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Daignose metadata #1524

Merged
merged 16 commits into from
Sep 22, 2024
Merged

feat: Daignose metadata #1524

merged 16 commits into from
Sep 22, 2024

Conversation

yodigos
Copy link
Contributor

@yodigos yodigos commented Sep 19, 2024

No description provided.


var (
diagnoseDirs = []string{LogsDir, CRDsDir}
CRDsList = []map[string]string{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any Ideas for doing the Actions part dynamically?
Someone who will add a new action will forget to add it here.

Copy link
Collaborator

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Left few nits

cli/cmd/diagnose.go Outdated Show resolved Hide resolved
cli/cmd/diagnose.go Outdated Show resolved Hide resolved
cli/cmd/diagnose.go Show resolved Hide resolved
cli/cmd/diagnose.go Show resolved Hide resolved
cli/cmd/diagnose.go Outdated Show resolved Hide resolved
cli/cmd/diagnose.go Outdated Show resolved Hide resolved
@yodigos yodigos merged commit e504bc4 into odigos-io:main Sep 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants