-
Notifications
You must be signed in to change notification settings - Fork 81
[IMP] environmental_agency: update environmental agency #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
[IMP] environmental_agency: update environmental agency #1232
Conversation
d7b96c7 to
3fc6374
Compare
| <field name="currency_id" ref="base.EUR"/> | ||
| <field name="invoice_currency_rate">1.0</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <field name="currency_id" ref="base.EUR"/> | |
| <field name="invoice_currency_rate">1.0</field> |
| <field name="invoice_currency_rate">1.0</field> | ||
| <field name="is_manually_modified" eval="True"/> | ||
| <field name="partner_id" ref="res_partner_37"/> | ||
| <field name="partner_shipping_id" ref="res_partner_37"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <field name="partner_shipping_id" ref="res_partner_37"/> | |
| <field name="quantity">5.0</field> | ||
| <field name="name">Office Chairs</field> | ||
| <field name="debit">75.0</field> | ||
| <field name="amount_currency">75.0</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <field name="amount_currency">75.0</field> | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The amount expressed in an optional other currency if it is a multi-currency entry.
| <field name="sequence">100</field> | ||
| </record> | ||
| <record id="esg_emission_factor_1657" model="esg.emission.factor"> | ||
| <field name="name">Grid electricity 2015 </field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <field name="name">Grid electricity 2015 </field> | |
| <field name="name">Grid electricity 2015</field> |
| <field name="price_unit">15.0</field> | ||
| <field name="display_type">product</field> | ||
| <field name="quantity">5.0</field> | ||
| <field name="name">Office Chairs</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <field name="name">Office Chairs</field> | |
| <field name="database_id" ref="esg.esg_database_ademe"/> | ||
| <field name="uom_id" ref="uom_uom_35"/> | ||
| <field name="compute_method">monetary</field> | ||
| <field name="currency_id" ref="base.EUR"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <field name="currency_id" ref="base.EUR"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pgu-odoo is right, it should use the one from the company or something like this (EUR may not be available)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a record of company which is activating this EURcurrency
<field name="partner_id" ref="base.main_partner"/>
<field name="name">Environmental Agency</field>
<field name="logo" type="base64" file="environmental_agency/static/src/binary/res_partner/37-image_1920"/>
<field name="email">hello@environmentalagency.example.com</field>
<field name="phone">+1 650-691-3277</field>
<field name="country_id" ref="base.be"/>
<field name="street">Avenue des déportés 48</field>
<field name="zip">1367</field>
<field name="city">Ramillies</field>
</record>```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh 🤔 then we maybe need to remove this, the company shouldn't be relocated to BE.
But here you could use the currency of the company (no matter how it is defined)
5daf193 to
ced6f40
Compare
|
@vava-odoo PR is ready for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done
| <record id="ir_cron_load_ademe_data" model="ir.cron"> | ||
| <field name="active">False</field> | ||
| </record> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice workaround with the cron 👍
I just wondered: would it make sense to keep it active afterwards? With a larger delay obviously (like every month or so). Maybe to discuss with Juliette
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should have this for longer period instead of archiving it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know the outcome of the discussion then
| @@ -0,0 +1,43 @@ | |||
| <?xml version='1.0' encoding='UTF-8'?> | |||
| <odoo noupdate="1"> | |||
| <record id="esg_emission_source_23" model="esg.emission.source"> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure we need to define all these? Aren't there defined here https://github.com/odoo/enterprise/blob/6dea842c2ed909971770cfc8018ef40ea8730800/esg/data/esg_emission_source_data.xml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we need to create it as those are different from the ones you mentioned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, not sure, but esg_emission_source_231 looks very similar to esg.esg_emission_source_indirect_1
maybe check all this with Juliette as well
| <field name="database_id" ref="esg.esg_database_ademe"/> | ||
| <field name="uom_id" ref="uom_uom_35"/> | ||
| <field name="compute_method">monetary</field> | ||
| <field name="currency_id" ref="base.EUR"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pgu-odoo is right, it should use the one from the company or something like this (EUR may not be available)
In this commit we have added following changes - Added the ESG app - Added gender, wage, department, position and contract type to employees - Added vendor bills - Updated the knowledge article - Assigned emissions to Emission Factors| Task-5111564
ced6f40 to
ede3d25
Compare
ede3d25 to
ce295bc
Compare


In this PR we have added following changes
Task-5111564