-
Notifications
You must be signed in to change notification settings - Fork 25.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] ir_sequence: Fix creating date_range_seq with range_month and range_day #91019
Conversation
Hi @mart-e Who could help us to review it? Thanks in advance! |
…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged
…ange_day Using range_day the range of the dates for new date_range_sequence record should be only one day Using range_month the range of the dates for new date_range_sequence record should be only one month Before of this fix the date created was a range of many days or months It fixes the range of new sequences Add new unittests
448802a
to
28eb14c
Compare
…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged
…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged
…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged
Hey @moylop260 ! Include the refactor on this PR too |
…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged
895eb36
to
cf3ce45
Compare
…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged
…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged
hi @mart-e, what is the state of this PR ? |
…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged
…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged
…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged
…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged
…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged
@william-andre I suppose this ain't a problem anymore. Maybe it's just worth checking the tests to see if it is indeed fixed, and see if this is tested or not. |
@qdp-odoo This PR is about I can take a closer look later, but I believe it would be a good idea to go further with this PR. (probably in 15.0 as 14.0 has been deprecated) |
I, indeed, asked you without even reading the diff and got confused 🙈 Sorry 'bout that. I don't understand the commit message, let's assume this either isn't important or is fixed, @moylop260 feel free to reopen and better explain if you think it's still needed. thanks for the contribution, anyway |
…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged
…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged
…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged
…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged
Using range_day the range of the dates for new date_range_sequence
record should be only one day
Using range_month the range of the dates for new date_range_sequence
record should be only one month
Before of this fix the date created was a range of many days or months
It fixes the range of new sequences
Add new unittests