19.0 real estate tutorial haman #1049
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
haman-odoo
force-pushed
the
19.0-real-estate-tutorial-haman
branch
from
3a46ead to
949b655
Compare
kmk142789
approved these changes
Dec 7, 2025
haman-odoo
force-pushed
the
19.0-real-estate-tutorial-haman
branch
10 times, most recently
from
96dc36b to
2b93d6f
Compare
bit-odoo
reviewed
Dec 9, 2025
There was a problem hiding this comment.
Hello @haman-odoo
You did a good job 👏
I have added some suggestions. And can you please improve your commit message, and pr message, and title regarding these guidelines - https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html
One more thing, writing a comment is a good idea. But i think it is good only if our code is complex or doing some magic things, etc.
Thanks
estate/__manifest__.py
Outdated
| 'category': 'Sales/Real Estate', | ||
| 'installable': True, | ||
| 'auto_install': False, | ||
| 'description': """Description text""", |
There was a problem hiding this comment.
I think we can add description after the name so others can read it easily.
estate/models/__init__.py
Outdated
| @@ -0,0 +1,4 @@ | |||
| from . import estate_property # noqa: F401 | |||
There was a problem hiding this comment.
Suggested change
| from . import estate_property # noqa: F401 | |
| from . import estate_property |
estate/models/estate_property.py
Outdated
Comment on lines
1
to
3
| from odoo import models, fields | ||
| from dateutil.relativedelta import relativedelta | ||
| from datetime import date |
There was a problem hiding this comment.
First, we can import external libraries.
estate/models/estate_property.py
Outdated
Comment on lines
10
to
27
| name = fields.Char(string="Property Title", required=True) | ||
| description = fields.Text(string="Description") | ||
| postcode = fields.Char(string="Postcode") | ||
| date_availability = fields.Date( | ||
| string="Available From", | ||
| default=lambda sself: date.today() + relativedelta(months=3), | ||
| copy=False | ||
| ) | ||
| expected_price = fields.Float(string="Expected Price", required=True) | ||
| selling_price = fields.Float( | ||
| string="Selling Price", | ||
| readonly=True, | ||
| copy=False | ||
| ) | ||
|
|
||
| bedrooms = fields.Integer(string="Bedrooms", default=2) | ||
| living_area = fields.Integer(string="Living Area (sqm)") | ||
| facades = fields.Integer(string="Number of Facades") |
There was a problem hiding this comment.
No need to declare a string if it is the same as the field name because Odoo can generate a string.
| _description = "Real Estate Property Offer" | ||
|
|
||
| price = fields.Float(string="Price") | ||
|
|
estate/models/estate_property_tag.py
Outdated
| _name = "estate.property.tag" | ||
| _description = "Real Estate Property Tag" | ||
|
|
||
| name = fields.Char(string="Name", required=True) |
estate/views/estate_menus.xml
Outdated
| @@ -0,0 +1,15 @@ | |||
| <!-- /home/odoo/odoo19/tutorials/estate/views/estate_menus.xml --> | |||
| @@ -0,0 +1,32 @@ | |||
| <!-- /home/odoo/odoo19/tutorials/estate/views/estate_property_offer_views.xml --> | |||
| @@ -0,0 +1,9 @@ | |||
| <!-- /home/odoo/odoo19/tutorials/estate/views/estate_property_type_views.xml --> | |||
| @@ -0,0 +1,124 @@ | |||
| <!-- /home/odoo/odoo19/tutorials/estate/views/estate_property_views.xml --> | |||
haman-odoo
force-pushed
the
19.0-real-estate-tutorial-haman
branch
from
2b93d6f to
8e3df8a
Compare
haman-odoo
force-pushed
the
19.0-real-estate-tutorial-haman
branch
from
8e3df8a to
d2aa309
Compare
haman-odoo
force-pushed
the
19.0-real-estate-tutorial-haman
branch
from
d2aa309 to
44f5059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Real Estate Tutorial