[FIX] util/orm.py: fix custom_module_field_as_manual transient access
#8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Author
|
@aj-fuentes |
aj-fuentes
requested changes
Nov 17, 2023
Contributor
|
upgradeci retry with always only base |
erl-odoo
force-pushed
the
master-custom-transient-models-access-erl
branch
from
177b790 to
6591347
Compare
aj-fuentes
reviewed
Nov 17, 2023
erl-odoo
force-pushed
the
master-custom-transient-models-access-erl
branch
from
6591347 to
95140d5
Compare
From Odoo version 14.0 transient models require access rights instead of implicit access (see related odoo/odoo#43306). This can lead to access errors in `custom_module_field_as_manual`, particularly in the upgrade TestCrawler, leading to blocked upgrades. To reproduce: - have a v13 db with a custom menu which opens a custom model's view, having a relational field (e.g. one2many) to a custom transient model, and have existing records - run the upgrade test prepare - upgrade to v14 - run the upgrade test check, the TestCrawler will fail with an AccessError To fix that, create temporary access rights for custom transient models while using the context manager. upg-1157201
erl-odoo
force-pushed
the
master-custom-transient-models-access-erl
branch
from
95140d5 to
9dd61af
Compare
Contributor
|
@robodoo r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Odoo version 14.0 transient models require access rights instead of
implicit access (see related odoo/odoo#43306). This can lead to access
errors in
custom_module_field_as_manual, particularly in the upgradeTestCrawler, leading to blocked upgrades.
To reproduce:
having a relational field (e.g. one2many) to a custom transient model,
and have existing records
AccessError
To fix that, create temporary access rights for custom transient models
while using the context manager.
upg-1157201