Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/numpy2 compatibility #1113

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Fix/numpy2 compatibility #1113

merged 4 commits into from
Oct 15, 2024

Conversation

p-snft
Copy link
Member

@p-snft p-snft commented Aug 22, 2024

It's almost impossible to have doctests that work with both, numpy 1.x and numpy 2.x: The string representations changed to include the data type. Example:

> data = numpy.array([1,2,3])
> print(data[1])  # no longer prints "2"
np.int64(2)

Introducing a lower bound to Pandas as well allows to remove Pandas <2.2 compatibility code.

This allows to work with numpy >= 2.0.0.
It's almost impossible to have doctests that work with both,
numpy 1.x and numpy 2.x. Introducin a lower bound to Pandas
as well allows to remove Pandas <2.2 compatibility code.
@p-snft p-snft added this to the minor release milestone Aug 22, 2024
@p-snft p-snft self-assigned this Aug 22, 2024
@p-snft p-snft requested a review from a team August 22, 2024 10:18
# Conflicts:
#	docs/whatsnew/v0-5-5.rst
#	src/oemof/solph/__init__.py
@p-snft
Copy link
Member Author

p-snft commented Oct 15, 2024

Tests fail just because of broken link check (GitHub seems to be locked out.) Will merge.

@p-snft p-snft merged commit c58e2d4 into release/v0.5 Oct 15, 2024
8 of 10 checks passed
@p-snft p-snft deleted the fix/numpy2_compatibility branch October 15, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant