Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema for Matroska v4 #9

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Conversation

chrmcg
Copy link
Contributor

@chrmcg chrmcg commented Feb 26, 2022

This PR updates lib/schema.js to include definitions from Matroska version 4.

To generate these changes, I parsed ebml_matroska.xml (referenced in https://www.matroska.org/technical/elements.html), then upserted the results into the existing schema.js list. Thus no elements were deleted, but many were updated.

This update allowed me to use ts-ebml to add a Range tag (defined in v4) to a WebM video generated in the browser. If anyone wants to do the same, you can update your package.json as follows (at least until this PR is accepted/published):

 "dependencies": {
    // ...
    "matroska": "https://github.com/ArcadeHQ/node-matroska.git#matroska-v4",
    "ts-ebml": "^2.0.2",
    // ...
  },
  "overrides": {
    "matroska": "https://github.com/ArcadeHQ/node-matroska.git#matroska-v4"
  },

Let me know if I can do anything to improve this PR or otherwise help out :)

@brianneisler
Copy link

hey @chrmcg, really appreciate your work here and we're about to use it in our own application to support Matroska v4.

Given that this package hasn't seen any movement in almost 5 years and it itself is a fork of node-ebml which has a new maintainer who's been recently active, maybe we could get this PR opened against that instead?

@oeuillot oeuillot merged commit 56c2b92 into oeuillot:master Mar 7, 2022
@chrmcg
Copy link
Contributor Author

chrmcg commented Mar 10, 2022

@oeuillot Thanks for the merge!

Any chance you could make an npm release for this change?

@oeuillot
Copy link
Owner

Yes ... I will do it !

@oeuillot
Copy link
Owner

I have pushed an updated version of package.json which includes security upgrades.
Can you check if it breaks something in your projects.
I don't have time to test it today (and tomorrow)
Thanks

@stijnvanderpol
Copy link

Hello 👋

Thanks @chrmcg for the PR and @oeuillot for the package. The latest version of master is working on my end. @oeuillot do you have an indication of when you're planning to publish version 2.2.4?

Thanks

@oeuillot
Copy link
Owner

oeuillot commented Apr 7, 2022

Done !

@nklhtv
Copy link
Contributor

nklhtv commented Apr 7, 2022

For me this fails with Error: Invalid ebmlName 'TimecodeScale'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants