Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign Exceptions #159

Closed
5 tasks done
offa opened this issue Jan 28, 2023 · 0 comments
Closed
5 tasks done

Redesign Exceptions #159

offa opened this issue Jan 28, 2023 · 0 comments
Assignees
@offa
Labels
api-change enhancement
Milestone
v0.7.0

Comments

@offa
Copy link
Owner

offa commented Jan 28, 2023 •
edited
Loading

There are some specific exception classes to the HTTP transport which aren't exported symbols. Most do represent HTTP status codes.

Things to consider:

  • Are the Http status exceptions necessary or can it fit into a single type with all information in it's message?
  • Are message prefix and source relevant to the caller?

Tasks:

  • Deprecate non-exported Exceptions (ETA removal: 0.8.0; Remove APIs marked for removal #165)
  • Remove usages of the now deprecated types
  • Add a message only exception ctor
  • Deprecate source / message exception ctor
  • Include message and error code in HTTP transport exceptions
@offa offa mentioned this issue Jan 28, 2023
Closed
6 tasks
@offa offa modified the milestones: v0.8.0, v0.7.0 Jan 31, 2023
@offa offa self-assigned this Feb 3, 2023
offa added a commit that referenced this issue Feb 9, 2023
@offa
Deprecate non-exported exceptions and source / message ctor; introduce
5df70f5 
single argument ctor (#159)
offa added a commit that referenced this issue Feb 9, 2023
@offa
Replace deprecated exception types (#159)
18f797d
@offa offa closed this as completed Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@offa offa

Labels
api-change enhancement
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
1 participant
@offa