Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace plain curl with CPR #93

Closed
6 tasks done
offa opened this issue Aug 4, 2021 · 0 comments
Closed
6 tasks done

Replace plain curl with CPR #93

offa opened this issue Aug 4, 2021 · 0 comments
Assignees
@offa
Labels
api-change enhancement
Milestone
v0.7.0

Comments

@offa
Copy link
Owner

offa commented Aug 4, 2021 •
edited
Loading

While the curl API does it's job it's still C. Replacing it with a more C++ like cpr API could simplify and improve the HTTP code (related: #90).

  • PoC
  • Update dependencies (incl. docs)
  • Review error handling of response status codes (eg. generic exception type with message and code?) (docs) — Redesign Exceptions #159
  • HTTP::influxDbServiceUrl() and HTTP::databaseName() still necessary?
  • Pass basic auth credentials by (name, pass) instead of auth string
  • Rename HTTP::enableBasicAuth()
@offa offa added this to the v0.7.0 milestone Aug 4, 2021
@offa offa changed the title Replace plain curl with a more suited API? Replace plain curl with a more suited API Aug 5, 2022
@offa offa removed the discussion label Aug 5, 2022
@offa offa self-assigned this Jan 17, 2023
@offa offa changed the title Replace plain curl with a more suited API Replace plain curl with CPR Jan 18, 2023
@offa offa mentioned this issue Jan 28, 2023
Closed
offa added a commit that referenced this issue Jan 28, 2023
@offa
Replace curl with cpr (#93)
4f1f45e
offa added a commit that referenced this issue Jan 28, 2023
@offa
Remove HTTP influxDbServiceUrl() and HTTP::databaseName() methods (#93)
57b6c42
offa added a commit that referenced this issue Jan 28, 2023
@offa
Pass basic auth by name and password (#93)
1d9eac4
@offa offa mentioned this issue Jan 30, 2023
Closed
@offa offa closed this as completed Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@offa offa

Labels
api-change enhancement
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
1 participant
@offa