Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auth token #214

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Support auth token #214

merged 2 commits into from
Oct 24, 2023

Conversation

offa
Copy link
Owner

@offa offa commented Oct 20, 2023

Adds support for auth token (http only).

The url format is similar to basic auth:

https://apitoken@host.com…

@offa offa added the feature label Oct 20, 2023
@offa offa added this to the v0.8.0 milestone Oct 20, 2023
@offa offa self-assigned this Oct 20, 2023
@offa offa linked an issue Oct 20, 2023 that may be closed by this pull request
@offa offa mentioned this pull request Oct 20, 2023
src/HTTP.cxx Outdated Show resolved Hide resolved
Copy link

@kasparthommen kasparthommen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, works as expected, thanks!

@offa offa merged commit 085e6db into master Oct 24, 2023
32 checks passed
@offa offa deleted the 90-authtoken branch October 24, 2023 15:06
@offa
Copy link
Owner Author

offa commented Oct 24, 2023

Thanks for your feedback!

@kasparthommen
Copy link

kasparthommen commented Oct 31, 2023

@offa Any chance you could release a new version/tag on the back of this pls?

@offa
Copy link
Owner Author

offa commented Oct 31, 2023

The next release (0.8.x) has quite some work to do, but I can backport and release as a 0.7.x if that helps.

@kasparthommen
Copy link

Yes please, if it's not too much trouble!

@offa
Copy link
Owner Author

offa commented Nov 3, 2023

@kasparthommen new release is available 🚀.

@kasparthommen
Copy link

Amazing, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Auth Token?
2 participants