Ensure that public headers are prefixed with 'InfluxDB". #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In vcpkg's registry, before microsoft/vcpkg-tool#1483 , we missed that `influxdb-cxx` conflicts with `libproxy`, because the former spells the header `include/Proxy.h` while the latter spells it `include/proxy.h`. This caused the ports to silently damage each other on case insensitive file systems, such as on Windows and macOS. Given that the names "Proxy.h", "Transport.h", and "Point.h" are all extremely likely to conflict with other users, and `influxdb-cxx` already seems to have a convention for header names to be prefixed with "InfluxDB", we, the vcpkg registry maintainers, believe it would be best if these headers were renamed to resolve the conflict.
|
🙈 Oh dear … Thank you for reporting. The convention is more or less class name = file name. I would suggest moving the files to a subdirectory called "include/InfluxDB/" instead of renaming them. The CMake files are installed in a similar subdirectory already. |
That would also work 👍. I'm less confident in making that change correctly myself :/ |
|
No problem, I'll take care of it. |
|
Could you give #264 a try? |
|
Obsoleted by #264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In vcpkg's registry, before microsoft/vcpkg-tool#1483 , we missed that
influxdb-cxxconflicts withlibproxy, because the former spells the headerinclude/Proxy.hwhile the latter spells itinclude/proxy.h. This caused the ports to silently damage each other on case insensitive file systems, such as on Windows and macOS.Given that the names "Proxy.h", "Transport.h", and "Point.h" are all extremely likely to conflict with other users, and
influxdb-cxxalready seems to have a convention for header names to be prefixed with "InfluxDB", we, the vcpkg registry maintainers, believe it would be best if these headers were renamed to resolve the conflict.