Remove check that _id is an instance of ObjectID #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome looks good, thanks @simonbengtsson ! |
officert
added a commit
that referenced
this pull request
Mar 10, 2016
Remove check that _id is an instance of ObjectID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a check that
_idis an instance ofObjectID. My understanding when reading the docs is that the_idis recommended to be an ObjectId, but that it is not required. When I tested with a database for parse-server (which uses strings as _id), updates to documents failed with the following errorInvalidArugmentError('objectId must be an instance of ObjectId');. With the check removed it worked perfectly.