feat: pass controller to serialize / deserialize (#50)

* feat: pass controller to `serialize` / `deserialize` * test(query-params): assert that the controller is passed to `serialize` / `deserialize`
offirgolan · Jan 19, 2018 · 26b1f43 · 26b1f43
1 parent db02625
commit 26b1f43
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 6 deletions.
diff --git a/addon/-private/parachute-event.js b/addon/-private/parachute-event.js
@@ -43,7 +43,7 @@ export default class ParachuteEvent {
      */
     this.changed = queryParamsArray.reduce((changedParams, qp) => {
       if (changedKeys.includes(qp.as)) {
-        changedParams[qp.key] = canInvoke(qp, 'deserialize') ? qp.deserialize(changed[qp.as]) : changed[qp.as];
+        changedParams[qp.key] = canInvoke(qp, 'deserialize') ? qp.deserialize(changed[qp.as], controller) : changed[qp.as];
       }
       return changedParams;
     }, {}, undefined);

diff --git a/addon/-private/query-param.js b/addon/-private/query-param.js
@@ -72,7 +72,7 @@ export default class QueryParam {
    */
   serializedValue(controller) {
     const value = this.value(controller);
-    return canInvoke(this, 'serialize') ? this.serialize(value) : value;
+    return canInvoke(this, 'serialize') ? this.serialize(value, controller) : value;
   }
 
   /**

diff --git a/addon/initializers/ember-parachute.js b/addon/initializers/ember-parachute.js
@@ -88,7 +88,7 @@ export function initialize(/* application */) {
         let queryParam = QueryParams.lookupQueryParam(controller, urlKey);
 
         if (canInvoke(queryParam, 'serialize')) {
-          return queryParam.serialize(value);
+          return queryParam.serialize(value, controller);
         }
       }
 
@@ -111,7 +111,7 @@ export function initialize(/* application */) {
         let queryParam = QueryParams.lookupQueryParam(controller, urlKey);
 
         if (canInvoke(queryParam, 'deserialize')) {
-          return queryParam.deserialize(value);
+          return queryParam.deserialize(value, controller);
         }
       }
 

diff --git a/tests/unit/query-params-test.js b/tests/unit/query-params-test.js
@@ -27,10 +27,12 @@ const queryParams = new QueryParams({
   colors: {
     defaultValue: [],
     refresh: true,
-    serialize(value) {
+    serialize(value, controller) {
+      assertController(controller);
       return value.toString();
     },
-    deserialize(value = '') {
+    deserialize(value = '', controller) {
+      assertController(controller);
       return value.split(',');
     }
   }
@@ -46,6 +48,12 @@ const defaultValues = {
 const Controller = Ember.Object.extend(queryParams.Mixin);
 let controller;
 
+function assertController(controller) {
+  if (!(controller instanceof Controller)) {
+    throw new Error('Expected the controller to be passed as the second parameter to serialize / deserialize.');
+  }
+}
+
 module('Unit | QueryParams', {
   beforeEach() {
     controller = Controller.create();