Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(cw-relayer): improvements #68

Merged
merged 14 commits into from
Apr 5, 2023
Merged

perf(cw-relayer): improvements #68

merged 14 commits into from
Apr 5, 2023

Conversation

dixitaniket
Copy link
Contributor

@dixitaniket dixitaniket commented Mar 13, 2023 •
edited
Loading

  • multiple event rpc in case to listen to ticks for price updates (switch rpc after a max set duration)
  • multiple query rpcs in case one fails to connect or returns empty prices
  • auto restart config, queries request, median and deviation ids, in case of restart or startup
  • docker test e2e wasmd set from latest to v0.30.0

@dixitaniket dixitaniket linked an issue Mar 20, 2023 that may be closed by this pull request
Relayer stops posting prices if there is an issue with query or event rpc #66
Closed
@dixitaniket dixitaniket marked this pull request as ready for review March 22, 2023 11:01
@dixitaniket dixitaniket requested a review from a team as a code owner March 22, 2023 11:01
@adamewozniak
Copy link
Member

@dixitaniket can you please describe all the improvements in the description?

@dixitaniket dixitaniket linked an issue Mar 27, 2023 that may be closed by this pull request
Add support to query prices and relay to multiple wasm supported chains #71
Open
@dixitaniket dixitaniket removed a link to an issue Mar 27, 2023
Add support to query prices and relay to multiple wasm supported chains #71
Open
@dixitaniket dixitaniket linked an issue Mar 27, 2023 that may be closed by this pull request
multiple query rpc's for querying prices #67
Closed
adamewozniak
adamewozniak approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly just format fixes, this implementation makes sense.

Let's add a section to the relayer readme for the multi-rpc config and how it's treated (completely random, weighted, etc)

cw-relayer/cmd/cw-relayer.go Outdated Show resolved Hide resolved
cw-relayer/relayer/client/chain_subscribe.go Outdated Show resolved Hide resolved
cw-relayer/relayer/client/chain_subscribe.go Outdated Show resolved Hide resolved
cw-relayer/relayer/client/chain_subscribe.go Outdated Show resolved Hide resolved
cw-relayer/relayer/client/chain_subscribe.go Show resolved Hide resolved
cw-relayer/relayer/client/chain_subscribe.go Outdated Show resolved Hide resolved
cw-relayer/relayer/relayer.go Show resolved Hide resolved
@adamewozniak
Copy link
Member

@dixitaniket please merge if this is ready to go

@dixitaniket dixitaniket merged commit a1fc167 into main Apr 5, 2023
@dixitaniket dixitaniket deleted the ani/improvements branch April 5, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamewozniak adamewozniak adamewozniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dixitaniket @adamewozniak