fix: make sidenav header optional, allow items to be not sortable #2442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/odyssey-react-mui/src/labs/SideNav/SortableList/SortableList.tsx
Outdated
Show resolved
Hide resolved
| @@ -134,7 +134,7 @@ const storybookMeta: Meta<SideNavProps> = { | |||
| }, | |||
| }, | |||
| args: { | |||
| appName: "Admin", | |||
| appName: "", | |||
There was a problem hiding this comment.
Would we expect an empty string here? Or, would the consumer just not provide the prop?
There was a problem hiding this comment.
This is just a test, but I guess it can be either way. I will update the prop to be optional.
ganeshsomasundaram-okta
force-pushed
the
gs-OKTA-842363-sidenav-enh
branch
from
599a139 to
7c34d50
Compare
packages/odyssey-react-mui/src/labs/SideNav/SortableList/SortableList.tsx
Show resolved
Hide resolved
bryancunningham-okta
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REPLACE_WITH_JIRA_TICKET_NUMBER
Summary
Testing & Screenshots