-
Notifications
You must be signed in to change notification settings - Fork 36
User menu button fixes #2467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User menu button fixes #2467
Conversation
4e95f47
to
686ed38
Compare
":dir(rtl)": { | ||
"&:before": { | ||
left: "unset", | ||
right: 0, | ||
...(verticalDividerAlignment === "end" && { | ||
right: "unset", | ||
left: 0, | ||
}), | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's all this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment. The rest looks fine.
686ed38
to
514e440
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I noticed Yarn.lock is changed though, just want to make sure that was intentional before you merge
DES-6997
Summary
Testing & Screenshots