Skip to content

User menu button fixes #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Conversation

bryancunningham-okta
Copy link
Contributor

@bryancunningham-okta bryancunningham-okta commented Jan 17, 2025

DES-6997

Summary

  • Adds ability to show vertical divider
  • Style UserProfileButton slightly differently(no set height, smaller block padding)
  • Adds back storybook rtl addon

Testing & Screenshots

  • I have confirmed this change with my designer and the Odyssey Design Team.

@bryancunningham-okta bryancunningham-okta requested a review from a team as a code owner January 17, 2025 19:53
@bryancunningham-okta bryancunningham-okta force-pushed the DES-6997-user-menu-butotn-fixes branch from 4e95f47 to 686ed38 Compare January 17, 2025 20:12
@KevinGhadyani-Okta KevinGhadyani-Okta changed the title User menu butotn fixes User menu button fixes Jan 17, 2025
Comment on lines +86 to +95
":dir(rtl)": {
"&:before": {
left: "unset",
right: 0,
...(verticalDividerAlignment === "end" && {
right: "unset",
left: 0,
}),
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's all this?

Copy link
Contributor

@KevinGhadyani-Okta KevinGhadyani-Okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. The rest looks fine.

Copy link
Contributor

@benlister-okta benlister-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I noticed Yarn.lock is changed though, just want to make sure that was intentional before you merge

@oktapp-aperture-okta oktapp-aperture-okta bot merged commit 3b78335 into main Jan 22, 2025
1 check passed
@oktapp-aperture-okta oktapp-aperture-okta bot deleted the DES-6997-user-menu-butotn-fixes branch January 22, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants