Switch to NodeNext module resolution #2478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benschell-okta
approved these changes
Jan 23, 2025
| import { type PaginationProps } from "../../Pagination"; | ||
| import { RowActionsProps } from "./RowActions"; | ||
| } from "./dataTypes.js"; | ||
| import { MenuButtonProps } from "../../index.js"; |
There was a problem hiding this comment.
it was "bad" before your change, but I'd recommend have this pull from Buttons/index.js (or wherever it is) rather than the top-level index.js
oktapp-aperture-okta
bot
deleted the
kg_use-nodenext-module-resolution-OKTA-856735
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-856735
Summary
Odyssey was using Bundler to build rather than NodeNext. This requires consumers to make changes to their TSConfig files. We don't want that.
After the recent changes to upgraded packages, we need to add
.jsto each local import with NodeNext module resolution.Testing & Screenshots