fix: Next.js esm and cjs issues with SSR #2491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's causing timing issues
bryancunningham-okta
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-858688
Summary
Inbox team uses Next.js, and you can't disable SSR. We found a workaround with dynamic imports, but we wanted a real fix as this also affects Workflows team.
To fix that issue, Odyssey needs to build in a way that's Node.js-friendly. It also needed to keep the existing functionality working with ESM exports and have it not error with SSR.
Part of the work was originally done by @benschell-okta to adjust output file extensions and adding a CJS build.
The work I did fixes the import/require resolutions and SSR issues.
Testing & Screenshots
N/A