Updating JA translation of ASA content #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for extraordinary-horse-71260e ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
In the latest translation update, the "title" attribute for the Okta Help Center logo was translated, which broke a test. It is preferable to have this string appear in JA rather than EN, thus refactoring the test.
paulwallace-okta
requested review from
mauriciocastillosilva-okta,
emikhasyak-okta,
pengyao-okta,
damianali-okta and
yasminvanya-okta
The top level menubar has links to product doc and release notes. Previously these pointed to JA pages, applying a fix here to avoid a regression of these URLs pointing to EN links.
mauriciocastillosilva-okta
approved these changes
Oct 10, 2022
| <div class="navbar"> | ||
| <div class="dropdown" data-mc-conditions="MultiProdPubish.DocMenu"> <button class="dropbtn">ドキュメント <i class="fa fa-caret-down"></i></button> <div class="dropdown-content"> | ||
| <div><a href="https://help.okta.com/ja-jp/Content/Topics/ReleaseNotes/okta-relnotes.htm">リリースノート</a> </div> | ||
| <div><a href="https://help.okta.com/ja-jp/Content/index.htm">製品ドキュメント</a> </div> |
There was a problem hiding this comment.
this changes we should automate, we have https://oktainc.atlassian.net/browse/OKTA-540003 for it
| </div> | ||
| <div> | ||
| <h2><a name="assign-users-or-groups-to-ASA"></a>ユーザーまたはグループを<span class="mc-variable okta-feature-names.ScaleFT variable">アドバンストサーバーアクセス</span><br />に割り当てる</h2> | ||
| <p>前の手順を終えると、属性の構成が完了し、使用を開始できます。<span class="mc-variable okta-feature-names.ScaleFT variable">アドバンストサーバーアクセス</span>に割り当てられたユーザーには、これらの属性が割り当てられます。「<a href="https://help.okta.com/okta_help.htm?type=oie&id=csh-assign-apps" target="_blank">アプリケーションのユーザーへの割り当て</a>」をご覧ください。</p> | ||
| <p>前の手順を終えると、属性の構成が完了し、使用を開始できます。<span class="mc-variable okta-feature-names.ScaleFT variable">アドバンストサーバーアクセス</span>に割り当てられたユーザーには、これらの属性が割り当てられます。「<a href="../../../../../../okta_help.htm?locale=ja-JP&type=oie&id=csh-assign-apps" target="_blank">アプリケーションのユーザーへの割り当て</a>」をご覧ください。</p> |
There was a problem hiding this comment.
This changes should be automated, https://oktainc.atlassian.net/browse/OKTA-538298 should take care of this
| @@ -328,6 +328,8 @@ <h1 class="relnotes">未翻訳のドキュメント</h1> | |||
| </div> | |||
| <!-- ********************** Scripts ************************************* --> | |||
| <!-- Foundation --> | |||
| <script src="../../Resources/Scripts/js/ignore-dompurify.js"> | |||
There was a problem hiding this comment.
https://oktainc.atlassian.net/browse/OKTA-538286 should take care of automating this (if needed)
There was a problem hiding this comment.
In this case, I believe we added the ignore-dompurify.js script to the EN doc after we sent this to translation. So, it'll be automatically included in future rounds.
| @@ -195,25 +195,25 @@ <h1>アドバンストサーバーアクセス</h1> | |||
| <p class="tile-subtitle"><span class="mc-variable okta-feature-names.ScaleFT variable">アドバンストサーバーアクセス</span>のチームをセットアップし、<span class="mc-variable okta-variables.ProductName variable">Okta</span>からユーザーとグループをプッシュします。</p> | |||
| </div> | |||
| <div> | |||
| <p class="tile-title">サーバーエージェント</p> | |||
| <p class="tile-title"><a href="sftd.htm">サーバーエージェント</a></p> | |||
There was a problem hiding this comment.
What happened here? Did XTM removed the <a> elements or the version we sent did not have it?
There was a problem hiding this comment.
We had missing links in the tiles at the time that we sent the project out (the issue was in source EN, it's been fixed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the deploy preview link to the ASA JA section: https://deploy-preview-478--extraordinary-horse-71260e.netlify.app/asa/ja-jp/content/topics/adv_server_access/docs/asa-overview