Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish scripts appear to be broken (Fix in comment) #376

Open
hcourse-nydig opened this issue Aug 3, 2021 · 0 comments · May be fixed by #377
Open

Fish scripts appear to be broken (Fix in comment) #376

hcourse-nydig opened this issue Aug 3, 2021 · 0 comments · May be fixed by #377

Comments

@hcourse-nydig
Copy link

hcourse-nydig commented Aug 3, 2021

Describe the bug
The fish scripts provide the profile to the aws command twice as they provide the first arg as profile (correct) then the entire arg list (inc. the profile) as a command to the aws cli tool.

To Reproduce
Steps to reproduce the behavior:

  1. Run okta-aws <profile> <valid command>
  2. See error re. invalid command

Expected behavior
It should work

Additional context
The fix is:

function okta-aws
    withokta "aws --profile $argv[1]" $argv[2..-1]
end

I would submit a PR but I can't push a new branch and your contribution guidelines don't mention anything about forking. I would fix this but having a busy day!

@hcourse-nydig hcourse-nydig changed the title Fish scripts appear to be broken Fish scripts appear to be broken (Fix in issue) Aug 3, 2021
@hcourse-nydig hcourse-nydig changed the title Fish scripts appear to be broken (Fix in issue) Fish scripts appear to be broken (Fix in comment) Aug 3, 2021
hcourse-nydig added a commit to hcourse-nydig/okta-aws-cli-assume-role that referenced this issue Aug 4, 2021
Removes first param from arg lists before calling aws cli. Fixes both bash and fish

Resolves: oktadev#375, oktadev#376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant