From ea088472580a0d52ab7cd09b12b38b381c78f1f4 Mon Sep 17 00:00:00 2001 From: okuzawats Date: Sun, 21 Jul 2024 05:55:56 +0900 Subject: [PATCH 1/4] deprecated messageType --- action.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/action.yml b/action.yml index 4ab7c48..b25dff7 100644 --- a/action.yml +++ b/action.yml @@ -12,6 +12,7 @@ inputs: roomId: required: true description: "Chatroom ID" + # deprecated inputs. this inputs parameter will be removed in the future version. messageType: description: "Message type to send. default is message." type: "choice" @@ -36,6 +37,11 @@ runs: fetch-depth: 0 - name: "set up ruby" uses: "ruby/setup-ruby@v1" + - name: "deprecate messageType" + if: ${{ !github.event.inputs.messageType }} + run: | + echo "::warning::messageType is now deprecated. If you use only message, just remove the parameter. Or if you use task, please use okuzawats/chatwork-task-action instead." + shell: "sh" - name: "run action" run: | ruby $GITHUB_ACTION_PATH/main.rb From 1e8e3fa9094eb6693c5f01d153689db2c1c0ebb3 Mon Sep 17 00:00:00 2001 From: okuzawats Date: Sun, 21 Jul 2024 05:59:10 +0900 Subject: [PATCH 2/4] deprecate userIdsToAssignTask --- action.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/action.yml b/action.yml index b25dff7..b77f2fb 100644 --- a/action.yml +++ b/action.yml @@ -24,6 +24,7 @@ inputs: message: required: true description: "Message to send" + # deprecated inputs. this inputs parameter will be removed in the future version. userIdsToAssignTask: required: false description: "User Id to be assigned to the task. Or you can specify multiple users, separated by commas. example 1,3,5" @@ -40,7 +41,7 @@ runs: - name: "deprecate messageType" if: ${{ !github.event.inputs.messageType }} run: | - echo "::warning::messageType is now deprecated. If you use only message, just remove the parameter. Or if you use task, please use okuzawats/chatwork-task-action instead." + echo "::warning::messageType is now deprecated. If you use only message, just remove the parameter. Or if you use task, please use okuzawats/chatwork-task-action instead. In this case, remove userIdsToAssignTask parameter also." shell: "sh" - name: "run action" run: | From 6dd8ba708ff79d10e1d8d1277beec35770deced1 Mon Sep 17 00:00:00 2001 From: okuzawats Date: Sun, 21 Jul 2024 05:59:35 +0900 Subject: [PATCH 3/4] update README to warn deprecated feature --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index fdf2c81..dda4004 100644 --- a/README.md +++ b/README.md @@ -22,6 +22,9 @@ Chatwork の Room にメッセージを送信する Action です。 message: 'ここにメッセージを書きます。' ``` +> [!WARNING] +> v1.1で導入されたタスク機能は、将来のバージョンから削除されます。代わりに[okuzawats/chatwork-task-action](https://github.com/okuzawats/chatwork-task-action)を使用してください。 + タスク機能にも対応しました(v1.1〜)。`messageType` と `userIdsToAssignTask` を追加してください。`userIdsToAssignTask` には複数IDを指定できます。カンマ区切りでユーザーIDを指定してください。 ```yml From 69f67489a818292b25f281e58bd31d5ed8971784 Mon Sep 17 00:00:00 2001 From: okuzawats Date: Sun, 21 Jul 2024 06:03:29 +0900 Subject: [PATCH 4/4] remove development step for task feature --- .github/workflows/development.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/development.yml b/.github/workflows/development.yml index e87cac7..73646aa 100644 --- a/.github/workflows/development.yml +++ b/.github/workflows/development.yml @@ -25,10 +25,3 @@ jobs: apiToken: "${{ secrets.API_KEY }}" roomId: "${{ secrets.ROOM_ID }}" message: "${{ env.MESSAGE }}" - - uses: ./ - with: - apiToken: "${{ secrets.API_KEY }}" - roomId: "${{ secrets.ROOM_ID }}" - message: "this is your task" - messageType: "task" - userIdsToAssignTask: "${{ secrets.USER_ID_1 }}"