Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pending mode for test #506

Merged
merged 5 commits into from
Dec 19, 2020
Merged

add pending mode for test #506

merged 5 commits into from
Dec 19, 2020

Conversation

summerpro
Copy link
Contributor

@summerpro summerpro commented Dec 17, 2020

From:cosmos/ethermint#571

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-io
Copy link

codecov-io commented Dec 17, 2020

Codecov Report

Merging #506 (5946b89) into dev (aeb74ad) will decrease coverage by 0.55%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #506      +/-   ##
==========================================
- Coverage   67.53%   66.97%   -0.56%     
==========================================
  Files         274      274              
  Lines       16414    16550     +136     
==========================================
  Hits        11085    11085              
- Misses       4711     4847     +136     
  Partials      618      618              
Impacted Files Coverage Δ
app/rpc/backend/backend.go 0.00% <0.00%> (ø)
app/rpc/namespaces/eth/api.go 0.00% <0.00%> (ø)
app/rpc/types/block.go 0.00% <0.00%> (ø)
app/rpc/types/utils.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb74ad...5946b89. Read the comment docs.

@summerpro summerpro requested a review from KamiD December 18, 2020 10:13
@xiangjianmeng xiangjianmeng merged commit 18bc7bf into dev Dec 19, 2020
@xiangjianmeng xiangjianmeng deleted the ray/add-eth-api branch December 19, 2020 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants