-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added features to load models from .gltf and .glb files. #211
Added features to load models from .gltf and .glb files. #211
Conversation
Hello @Jaemin-VIRNECT, Thank you so much for this PR! I'll review it on the weekend and if everything is good publish a new version. Meanwhile, could you please make sure you are not using "print" in the production code and that all files are formatted? Was there a reason to bump the minimum SDK version? Thanks again! Kind regards, |
Hello @olexale , I checked my PR again and it seems that my NodeBuilder.swift is using the print(). If there is a problem with the file format, etc., would you please change it? And about the minimum SDK version, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your PR! I bet many engineers would love to see this functionality. My initial idea was to keep only pure ARKit functionality without any 3rd-party SDKs, but I can admit that many devs would love to be able to use .glb and .gltf files in their projects, so let's add it.
I've added a few comments and propositions to the PR. Please have a look.
I might be able to help you with PR next weekend if you do not make changes before that.
Thanks again for your efforts!
Thanks again, @Jaemin-VIRNECT! I'll make some clean up (unrelated to your changes) in the plugin and release a new version with your contribution soon! |
I just pushed version |
Thank you so much! @olexale |
Added features to load models from .gltf and .glb files. (using GLTFSceneKit)
And examples also added.