Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publish and doctest fields. #88

Merged
merged 2 commits into from
Oct 21, 2019
Merged

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 10, 2019

publish added in 1.39 in rust-lang/cargo#7354.
doctest added in 1.37 in rust-lang/cargo#6953.

src/lib.rs Outdated
/// Whether or not this target has doc tests enabled, and the target is
/// compatible with doc testing.
///
/// This is `None` if running with a version of Cargo older than 1.37.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that is the only condition making it None, I think I'd prefer it to default to true if missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I was a little concerned that it would be misleading when running on older versions, but it's probably not a big deal.

@oli-obk oli-obk merged commit f049869 into oli-obk:master Oct 21, 2019
@ehuss ehuss mentioned this pull request Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants