Nonsensical comparisons with typeof and "null"

[evanw]

Describe the bug
This is a friendly FYI. This repo has some nonsensical code that compares the typeof operator with "null" even though that comparison will always be false (the value "null" is never returned by that operator). This came up because a build tool automatically reported the issue: evanw/esbuild#358.

There are at least two places in your code where this happens:

tabulator/src/js/modules/download.js

Line 133 in 9489e09

headers[i] = typeof col.value == "undefined" || typeof col.value == "null" ? "" : col.value;

and

tabulator/src/js/modules/clipboard.js

Lines 95 to 101 in 9489e09

	switch(typeof col.value){
	case "object":
	value = JSON.stringify(col.value);
	break;
	case "undefined":
	case "null":

I'm reporting this to you because this probably indicates the presence of a bug. Presumably this code is trying to check for col.value === undefined || col.value === null. There is probably a bug here because typeof null === "object" in JavaScript, not "null".

It's up to you if you want to do anything with this information. Even if it's not a bug, removing the nonsensical code would be appreciated because it would avoid this package being flagged by other tools.

Tabulator Info
This code is present on master.

[olifolkerd]

Thanks for the heads up. I will get those fixed in the 4.8 release next weekend

Cheers

Oli :)

[olifolkerd]

I have pushed fixes for these to the 4.8 branch for release next weekend.

Cheers

Oli :)