Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update Llama.cpp Server. It now Supports Llava 1.6 Image Embedding Dimension properly. #2795

Closed
chigkim opened this issue Feb 27, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@chigkim
Copy link

chigkim commented Feb 27, 2024

Last week pr/5553 was merged into Llama.cpp, and Llama.cpp server now supports llava 1.6 image embedding dimension properly.
This improves the accuracy greatly, and processes images in 4x larger dimension.
Could you guys update?
Thanks!

@jmorganca
Copy link
Member

This should be fixed now. Thanks for the issue!

@chigkim
Copy link
Author

chigkim commented Apr 16, 2024

Thanks!

Could you also merge this?

ggerganov/llama.cpp#5896

Right now Ollama reports prompt with image as 0 token when accessing with api.

Should I create it a separate issue?

@chigkim
Copy link
Author

chigkim commented Apr 16, 2024

I just created a new issue for it.
#3671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants