Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No named URL resolution in Django #831

Closed
cassidylaidlaw opened this issue Jan 30, 2016 · 3 comments
Closed

No named URL resolution in Django #831

cassidylaidlaw opened this issue Jan 30, 2016 · 3 comments

Comments

@cassidylaidlaw
Copy link

The included Django auth app allows for using named URLs in the settings, like so:

LOGIN_REDIRECT_URL = 'my_url'

However, trying to do the same in python-social-auth produces an error because the named URL isn't resolved when the Django strategy retrieves it from the settings.

@webjunkie
Copy link
Contributor

I had the same problem, but now I don't... and the redirect does seem to use Django's shortcut that also resolves URLs: 0220ae2

Can you point to where it does not resolve for you?

@webjunkie
Copy link
Contributor

Today I ran into the issue again. The problem is when PSA pulls the non-resolved URLs from the settings, they don't appear as valid URLs and are thus not taken into account when redirecting e.g. a new user. I'm going to do a pull request.

@omab
Copy link
Owner

omab commented Dec 13, 2016

@omab omab closed this as completed Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants