From c6b8f93d36d221aef9c8226d8cf103cfbde5e23b Mon Sep 17 00:00:00 2001
From: Angel Martinez <angel@rti.com>
Date: Tue, 21 Mar 2023 22:54:10 +0100
Subject: [PATCH] Fix warnings in the to_string functions of QoSes & reducing
 timeout of interoperability_report.py (#9)

* Fix warnings in the to_string functions of QoSes

* Reducing the timeout to improve performance in GitHub actions
---
 interoperability_report.py | 2 +-
 srcCxx/shape_main.cxx      | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/interoperability_report.py b/interoperability_report.py
index 5955eaa..768ed21 100644
--- a/interoperability_report.py
+++ b/interoperability_report.py
@@ -686,7 +686,7 @@ def main():
     # applications. A TestSuite contains a collection of TestCases.
     suite = junitparser.TestSuite(f"{name_publisher}---{name_subscriber}")
 
-    timeout = 10
+    timeout = 5
     now = datetime.now()
 
     t_suite_module = importlib.import_module(options['test_suite'])
diff --git a/srcCxx/shape_main.cxx b/srcCxx/shape_main.cxx
index 44e7ca5..2163f3d 100644
--- a/srcCxx/shape_main.cxx
+++ b/srcCxx/shape_main.cxx
@@ -77,6 +77,7 @@ class QosUtils {
         } else if (reliability_value == RELIABLE_RELIABILITY_QOS){
             return "RELIABLE";
         }
+        return "Error stringifying Reliability kind.";
     }
 
     static std::string to_string(DurabilityQosPolicyKind durability_value)
@@ -90,6 +91,7 @@ class QosUtils {
         } else if (durability_value == PERSISTENT_DURABILITY_QOS){
             return "PERSISTENT";
         }
+        return "Error stringifying Durability kind.";
     }
 
     static std::string to_string(DataRepresentationId_t data_representation_value)
@@ -99,6 +101,7 @@ class QosUtils {
         } else if (data_representation_value == XCDR2_DATA_REPRESENTATION){
             return "XCDR2";
         }
+        return "Error stringifying DataRepresentation.";
     }
 
     static std::string to_string(Verbosity verbosity_value)
@@ -116,6 +119,7 @@ class QosUtils {
         default:
             break;
         }
+        return "Error stringifying verbosity.";
     }
 
     static std::string to_string(OwnershipQosPolicyKind ownership_kind_value)
@@ -125,6 +129,7 @@ class QosUtils {
         } else if (ownership_kind_value == EXCLUSIVE_OWNERSHIP_QOS){
             return "EXCLUSIVE";
         }
+        return "Error stringifying Ownership kind.";
     }
 
     static std::string to_string(HistoryQosPolicyKind history_kind_value)
@@ -134,6 +139,7 @@ class QosUtils {
         } else if (history_kind_value == KEEP_LAST_HISTORY_QOS){
             return "KEEP_LAST";
         }
+        return "Error stringifying History kind.";
     }
 };