Support JPY currency #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective reason
This PR contains main 3 things,
Omise-Pluginlibrary, it contains necessary classes, files that we always used in every of our plugins. So, instead of implement classes, helper methods repeatedly every time we integrate, just copy this one and use everywhere.and few changes,
2. Description of change
3. Developers affected by the change
-4. Impact of the change
-5. Priority of change
🌟 🌟 🌟
6. Alternate solution (if any)**
-noted: JP translation, UI improvement are coming very soon (next PR)