Add supported for SSL configuration when create link through Url class #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective reason
To support OpenCart SSL configuration.
If we look at the core code:
so, we could just add a param at the 3rd arg of that
Url::link()
method to tell OpenCart that we will use "SSL" config if it's possible (config_secure
=true
).i.e.
$this->url->link('some/url', '', 'SSL'));
2. Description of change
src/catalog/controller/payment/omise.php
to supportSSL
config3. Users affected by the change
None
4. Impact of the change
None, it still support for
http
as normal.5. Priority of change
Normal.
6. Alternate solution (if any)
No.