Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add destroy method for Link #39

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Add destroy method for Link #39

merged 1 commit into from
Feb 11, 2021

Conversation

som-m
Copy link
Contributor

@som-m som-m commented Jan 28, 2021 •
edited
Loading

Summary

  • Add destroy method for Link (Omise doc)
  • Add test

QA

You should be able to destroy a link.

  1. Retrieve a link
    link = Omise::Link.retrieve("link_test_5ll4klw6mopf4nh4bi5")

  2. Destroy the link
    link.destroy

  3. Check whether the link has been destroyed
    link.destroyed?

zentetsukenz
zentetsukenz approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@zentetsukenz zentetsukenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tiponche
tiponche approved these changes Feb 3, 2021
View reviewed changes
Copy link

@tiponche tiponche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@danfowler danfowler closed this Feb 11, 2021
@danfowler danfowler reopened this Feb 11, 2021
@som-m som-m merged commit a9ec2b1 into omise:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zentetsukenz zentetsukenz zentetsukenz approved these changes

@tiponche tiponche tiponche approved these changes

@danfowler danfowler danfowler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@som-m @danfowler @tiponche @zentetsukenz