separate class for file get contents

omise · Oct 16, 2023 · 0d4e32f · 0d4e32f
1 parent 9a1a3d6
commit 0d4e32f
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 1 deletion.
diff --git a/includes/gateway/class-omise-payment-promptpay.php b/includes/gateway/class-omise-payment-promptpay.php
@@ -96,7 +96,7 @@ public function init_form_fields() {
 	 * @param string $id Value to be added in the id attribute of the svg element
 	 */
 	private function load_qr_svg_to_DOM($url, $id = null) {
-		$svg_file = $this->file_get_contents($url);
+		$svg_file = File_Get_Contents_Wrapper::get_contents($url);
 
 		$find_string   = '<svg';
 		$position = strpos($svg_file, $find_string);

diff --git a/includes/libraries/omise-plugin/Omise.php b/includes/libraries/omise-plugin/Omise.php
@@ -6,3 +6,4 @@
 require_once dirname(__FILE__).'/helpers/request.php';
 require_once dirname(__FILE__).'/helpers/token.php';
 require_once dirname(__FILE__).'/helpers/RedirectUrl.php';
+require_once dirname(__FILE__).'/helpers/file_get_contents_wrapper.php';
diff --git a/includes/libraries/omise-plugin/helpers/file_get_contents_wrapper.php b/includes/libraries/omise-plugin/helpers/file_get_contents_wrapper.php
@@ -0,0 +1,15 @@
+<?php
+
+/**
+ * file_get_contents wrapper class
+ * 
+ * Since we cannot mock global function,
+ * we have to create a wrapper for file_get_contents.
+ */
+class File_Get_Contents_Wrapper
+{
+	public static function get_contents($url)
+	{
+		return file_get_contents($url);
+	}
+}
diff --git a/tests/unit/includes/gateway/class-omise-payment-promptpay-test.php b/tests/unit/includes/gateway/class-omise-payment-promptpay-test.php
@@ -10,6 +10,7 @@ class Omise_Payment_Promptpay_Test extends Omise_Payment_Offline_Test
     public $mockOmisePluginHelper;
     public $mockOmisePaymentOffline;
     public $mockOmiseCharge;
+    public $mockFileGetContent;
 
     public function setUp(): void
     {
@@ -23,6 +24,7 @@ function admin_url() {}
         $this->mockOmisePluginHelper = Mockery::mock('overload:OmisePluginHelperWcOrder')->shouldIgnoreMissing();
         $this->mockOmisePaymentOffline = Mockery::mock('overload:Omise_Payment_Offline');
         $this->mockOmiseCharge = Mockery::mock('overload:OmiseCharge');
+        $this->mockFileGetContent = Mockery::mock('overload:File_Get_Contents_Wrapper');
 
         require_once __DIR__ . '/../../../../includes/gateway/class-omise-payment-promptpay.php';
     }
@@ -34,6 +36,8 @@ public function textExpiresAtFieldIsPassedToJavascript()
     {
         $expiresAt = '2023-11-22T14:48:00.000Z';
 
+        $this->mockFileGetContent->shouldReceive('get_contents')->once();
+
         $this->mockOmisePaymentOffline->shouldReceive('init_settings');
         $this->mockOmisePaymentOffline->shouldReceive('get_option');
         $this->mockOmisePaymentOffline->shouldReceive('load_order')->andReturn(true);