Client usage tracking #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnas
previously approved these changes
Jan 31, 2024
| * @param string $plugin_version | ||
| * @param string $api_key | ||
| */ | ||
| public function __construct( string $api_key, string $plugin_name, string $plugin_version ) { |
There was a problem hiding this comment.
Maybe throw error here? User shouldn't encounter this error as dev will be forced to provide value
There was a problem hiding this comment.
I try not to break client website. Throwing error could take all website down, I think we should avoid this. This class will not be created directly. Only trough Factory, where we ask to provide values, I think this should be enough to inform about this requirement.
| class Omnisend { | ||
|
|
||
| /** | ||
| * @param $plugin string plugin using client name |
There was a problem hiding this comment.
add comment what this function does
rokeras
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://omnisend.atlassian.net/browse/INT-782