-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xform to attachment model #2587
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukanga
changed the title
FA|KM|DU: Add xform to attachment model
Add xform to attachment model
Apr 15, 2024
ukanga
force-pushed
the
attachment-xform-direct-link
branch
3 times, most recently
from
April 17, 2024 18:49
de0e362
to
7ef557a
Compare
ukanga
force-pushed
the
attachment-xform-direct-link
branch
2 times, most recently
from
April 18, 2024 06:21
05785b0
to
4663cb4
Compare
Co-authored-by: Frankline Apiyo <franklineapiyo@gmail.com> Co-authored-by: Kelvin Muchiri <kelvinmuchiri63@gmail.com>
Co-authored-by: Kip <arapgodsmack@gmail.com>
…s been specified.
kelvin-muchiri
force-pushed
the
attachment-xform-direct-link
branch
from
April 22, 2024 07:06
4663cb4
to
34d4688
Compare
ukanga
commented
Apr 22, 2024
onadata/apps/logger/migrations/0014_populate_attachment_xform.py
Outdated
Show resolved
Hide resolved
onadata/apps/logger/migrations/0014_populate_attachment_xform.py
Outdated
Show resolved
Hide resolved
KipSigei
approved these changes
Apr 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Add a direct link between an attachment to the XForm (form for the submission the attachment belongs to) and User (submitted user) models.
Steps taken to verify this change does what is intended
Side effects of implementing this change
Existing records will have the field blank and may need to be updated to have this value for the benefit to be optimal for old records.
Before submitting this PR for review, please make sure you have:
Closes #