Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add distributed ranges as experimental feature. #1479
base: main
Are you sure you want to change the base?
Add distributed ranges as experimental feature. #1479
Changes from 91 commits
318f723
1ac29d0
8557b72
440e673
2f4897f
9189849
11fdbe7
e371685
cd56589
9e97305
d492476
477b204
0152437
5e43e65
2f84319
bc74b46
658e465
8e943bb
f31af79
35bb6bf
80cf60b
89c92c3
60884a2
ddaf6fe
797498d
03c69f1
1047d4a
db83006
5e98434
c2e3911
9fd9ac0
efaf73b
c968195
976bee4
8aa96ff
54eecda
232bf8e
b6f7c14
969cb75
e46716d
35683c2
60beae2
6e17faa
7251f36
78fdcfe
bdfcbe7
08a5273
093834d
21a321e
e3c6b26
f7c82cc
7a0673b
8c89e36
dcd1702
791d5c2
98b8034
00673f5
86f8da5
e4c19f1
5d46146
9223c15
ee243fb
c09ef4b
9944c46
c90223d
ee47222
5065839
f9c9a99
1236faf
e775386
1d1367a
4e3a8c6
f7149f8
0fdff35
8e3e60d
1fd08e6
88c5181
3830442
798b1e9
648eb43
962e671
8e531af
41e2228
b033088
177daaf
4c5fc67
b0cd793
c3bc4ff
81fb32e
3ca7233
e760ce0
cc69962
b3e15fd
d6f21d3
917eeb7
530380b
f3a1df5
3557043
68f59fe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an intention to keep a
distributed-ranges
active development branch which is distinct from main?If not, this probably should be removed before merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is indeed no such intention. This is a temporary line. Let's keep this comment unresolved until the branch is approved to be merged and I will remove this line that time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this part of the copyright header should not be used within DR, since it does not inherit nor use any LLVM work. It should only apply to the standard parallel algorithms in oneDPL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This macro doesn't work on Microsoft. Let's use
_ONEDPL___cplusplus
or whatever it's calledThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The biggest question is why those concepts are public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is good to make these concepts public. At the very least, it makes the documentation clearer, but also it allows someone to implement their own variations of distributed containers, etc. And it certainly facilitates possible discussions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we potentially end up with the name conflict for
ranges
namespace name? My guess is we should not based on my knowledge of lookup rules but do we want to change this line and the lines below todr::ranges
just to be safe?To be honest I don't have a strong preference