Allow eval call to set env variables #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| # docker-vpn-helper | |||
| s# docker-vpn-helper | |||
There was a problem hiding this comment.
Looks like there's an extra char here
|
@jmahowald Sorry for the delay...it looks like I screwed up my GH notification options at some point in time. |
| @@ -156,6 +156,9 @@ export DOCKER_CERT_PATH=/Users/jonathan.li/.docker/machine/machines/default | |||
| export DOCKER_MACHINE_NAME=default | |||
| ``` | |||
|
|
|||
|
|
|||
| You can rerun with eval $(docker-vpn-helper) to set your environment variables | |||
There was a problem hiding this comment.
I think it might make more sense to:
- insert this between the existing steps 3 and 4
- update the existing step 4 to note that the explicit
exports are not required if you re-ran the script witheval $(./docker-vpn-helper)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One small change and it's easy to have a more docker style setup for setting environment variables).
And thank you thank you thank you for making this. My previous workflow was untenable when using any connect