Unknown chunks auto-identification (padding) #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkaiser
force-pushed
the
padding-auto-id
branch
from
d0aa389 to
89f76da
Compare
e3krisztian
reviewed
Jan 2, 2024
qkaiser
force-pushed
the
padding-auto-id
branch
2 times, most recently
from
faf2218 to
a3f679b
Compare
|
@e3krisztian applied your recommendation, fixed the commit message, and rebased |
e3krisztian
reviewed
Jan 3, 2024
Integrate pattern recognition for unknown chunks in order to help identifying parts. Here we simply detect padding, but this could be extended in the future to detect re-occuring patterns, encrypted content, or even fingerprints. Co-authored-by: Krisztián Fekete <1246751+e3krisztian@users.noreply.github.com>
qkaiser
force-pushed
the
padding-auto-id
branch
from
a3f679b to
89cd491
Compare
e3krisztian
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects whether unknown chunks are made of single byte padding.