Skip to content
This repository has been archived by the owner on Apr 28, 2022. It is now read-only.

Fix JSONException with test orders #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mullpav
Copy link

@mullpav mullpav commented Oct 8, 2015

@RomanZhilich
Copy link
Collaborator

Hm.. If order id is null, doesn't it mean that purchase is broken? I'm pretty sure this field is mandatory.

EDIT: Oh, sorry. I see it's for test purchases. But then there should be some way to distinguish test purchases from regular ones.

@mullpav
Copy link
Author

mullpav commented Oct 8, 2015

Thanks for a response.
Here (http://developer.android.com/google/play/billing/billing_testing.html) is the following note:
Note: For test subscription purchases, leave the orderId field blank. You can use the purchaseToken field to identify test purchases.

@RomanZhilich
Copy link
Collaborator

Thanks for your fix. I'll think a bit about adding some sort of test mode and merge this commit. There's few other fixes I wanted to add so expect it in a week or so.

Also it might be more convenient to pull request in dev branch.

@mullpav
Copy link
Author

mullpav commented Oct 8, 2015

Great, thank you!

Oh, sorry about the pull request in master branch, my fault.

@mullpav
Copy link
Author

mullpav commented Nov 27, 2015

Hi, any news regarding an integration of a/this fix for test orders? Thanks.

@RomanZhilich
Copy link
Collaborator

Aw snap. I got ill and then it totally got out of my head. I'll do tomorrow, for sure...

@RomanZhilich
Copy link
Collaborator

Can you please try this out and confirm it works.
Don't forget to set debug mode in GoogleBillingProvider.Builder

@mullpav
Copy link
Author

mullpav commented Dec 1, 2015

Thank you, it works with google play test purchases with the .setDebugMode(true) set.

Just for check, without the debug mode it fails in the GoogleBillingProvider with "org.json.JSONException: orderId value is null." returning the Status.UNKNOWN_ERROR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants