Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Update model Block REST API Response #6884

Conversation

UlyanaAndrukhiv
Copy link
Contributor

@UlyanaAndrukhiv UlyanaAndrukhiv commented Jan 14, 2025

Closes: #6874

Related PR:

Context

The omitempty tag was added to the Expandable field for Block, flow package version updated

@UlyanaAndrukhiv UlyanaAndrukhiv requested a review from a team as a code owner January 14, 2025 14:28
@UlyanaAndrukhiv UlyanaAndrukhiv self-assigned this Jan 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.15%. Comparing base (f00769a) to head (a8bdf3b).

Files with missing lines Patch % Lines
engine/access/rest/common/models/block.go 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6884      +/-   ##
==========================================
- Coverage   41.16%   41.15%   -0.02%     
==========================================
  Files        2131     2131              
  Lines      186932   186946      +14     
==========================================
- Hits        76959    76938      -21     
- Misses     103536   103565      +29     
- Partials     6437     6443       +6     
Flag Coverage Δ
unittests 41.15% <86.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Guitarheroua Guitarheroua self-assigned this Jan 22, 2025
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. please update the import version to v0.4.9

@peterargue peterargue added this pull request to the merge queue Feb 13, 2025
Merged via the queue into onflow:master with commit b762bde Feb 14, 2025
56 checks passed
@peterargue peterargue deleted the UlianaAndrukhiv/6874-update-rest-block-response branch February 14, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Update model Block REST API Response
5 participants