Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Injection Grammar Support: Styled-components extension not working #2118

Open
pmizio opened this issue Jul 16, 2020 · 5 comments
Open

Injection Grammar Support: Styled-components extension not working #2118

pmizio opened this issue Jul 16, 2020 · 5 comments
Labels
A-extension Area: Extension/plugin integration, vscode or VimL A-syntax-highlighting Area: Syntax Highlighting enhancement New feature or request I-daily-editor-blocker An issue blocking use of the editor as a day-to-day editor

Comments

@pmizio
Copy link

pmizio commented Jul 16, 2020

Like in title extension not crash oni but syntax higlighting in template literals not work nor there not any code completion for css properties. Tested on lastest oni extension installed via --install-extension flag. I think it is very popular staff in react world and support for it should matter ;)
Extension link: https://open-vsx.org/extension/jpoissonnier/vscode-styled-components
@CrossR CrossR added A-syntax-highlighting Area: Syntax Highlighting enhancement New feature or request labels Jul 16, 2020
@CrossR
Copy link
Member

CrossR commented Jul 16, 2020

I believe right now we don't support embedded syntaxes, which would cause this issue. I could have missed some updates/be confused with something else though. We would like to support them!

@bryphe bryphe added the A-extension Area: Extension/plugin integration, vscode or VimL label Jul 18, 2020
@bryphe
Copy link
Member

bryphe commented Aug 15, 2020

We're missing support for 'Injection Grammars': https://code.visualstudio.com/api/language-extensions/syntax-highlight-guide#injection-grammars - grammars that extend existing textmate grammars

@bryphe bryphe changed the title styled-components extension not working Injection Grammar Support: Styled-components extension not working Aug 15, 2020
@pmizio
Copy link
Author

pmizio commented Aug 15, 2020

Just for information, how far it is on wait queue? Unfortunately for me as react dev it is daily blocker.

@bryphe bryphe added the I-daily-editor-blocker An issue blocking use of the editor as a day-to-day editor label Aug 18, 2020
@bryphe
Copy link
Member

bryphe commented Aug 18, 2020

Hi @miziak - unfortunately I didn't plan it for it for the Oct / 0.6.0 milestone (and it's already pretty packed!). I marked as a daily-editor-blocker and will look at it for the 0.7.0 milestone

@bryphe bryphe mentioned this issue Aug 27, 2020
Closed
@yunti
Copy link

yunti commented Aug 28, 2020 •
edited
Loading

Yup this is a daily blocker for me too. (the injection grammar support - not the specific bit related to styled components).

@bryphe bryphe mentioned this issue Jan 15, 2021
Open
@pmizio pmizio mentioned this issue Jan 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-extension Area: Extension/plugin integration, vscode or VimL A-syntax-highlighting Area: Syntax Highlighting enhancement New feature or request I-daily-editor-blocker An issue blocking use of the editor as a day-to-day editor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yunti @pmizio @CrossR @bryphe