fix(syntax/#2985): PHP syntax highlights not showing #2997
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: PHP syntax highlights are no longer showing by default
Defect: #2889 upgraded the extensions, but the PHP extension has a new dependency on
embeddedLanguages
, which our current textmate implementation does not handle correctlyFix: Remove the
embeddedLanguages
for now - add a regression / canary test to ensure we don't break this in the future.Fixes #2985
Tracking
embeddedLanguage
support in #2998