Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(syntax/#2985): PHP syntax highlights not showing #2997

Merged
merged 6 commits into from
Jan 15, 2021

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Jan 15, 2021

Issue: PHP syntax highlights are no longer showing by default

Defect: #2889 upgraded the extensions, but the PHP extension has a new dependency on embeddedLanguages, which our current textmate implementation does not handle correctly

Fix: Remove the embeddedLanguages for now - add a regression / canary test to ensure we don't break this in the future.

Fixes #2985
Tracking embeddedLanguage support in #2998

@bryphe bryphe merged commit a4661f7 into master Jan 15, 2021
@bryphe bryphe deleted the fix/syntax/2985/php-regression branch January 15, 2021 23:26
@nerdo
Copy link

nerdo commented Feb 15, 2021

There still seems to be an issue with this fix.

I was able to open a single PHP file and see syntax highlighting, but when I open more PHP files in my project, they do not have syntax highlighting.

@nerdo
Copy link

nerdo commented Feb 15, 2021

I just did a little bit more tinkering and figured out what seemed to break it.

  1. Open any number of PHP files
  2. Open a file without syntax highlighting (in my case, I opened a Laravel log file)
  3. Subsequent files no longer seem have syntax highlighting applied. It doesn't seem to matter if they are PHP files or other types in my case.

OniVim v0.5.9-nightly ad85033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP: Syntax highlighting does not appear to work at all
2 participants