From 170cd5cc33d1bca6415eda3f983379c2c6eef40b Mon Sep 17 00:00:00 2001 From: Magnus Ottenklinger Date: Wed, 14 Jul 2021 16:25:45 +0200 Subject: [PATCH 1/3] Bump Credo to ~>1.0 --- mix.exs | 2 +- mix.lock | 12 ++++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/mix.exs b/mix.exs index c106a55..c5e3afc 100644 --- a/mix.exs +++ b/mix.exs @@ -25,7 +25,7 @@ defmodule LoggerFileBackend.Mixfile do end defp deps do - [{:credo, "~> 0.4", only: [:dev, :test]}, + [{:credo, "~> 1.0", only: [:dev, :test]}, {:ex_doc, ">= 0.0.0", only: :dev}] end end diff --git a/mix.lock b/mix.lock index e883138..a87dfe5 100644 --- a/mix.lock +++ b/mix.lock @@ -1,4 +1,8 @@ -%{"bunt": {:hex, :bunt, "0.2.0", "951c6e801e8b1d2cbe58ebbd3e616a869061ddadcc4863d0a2182541acae9a38", [:mix], []}, - "credo": {:hex, :credo, "0.6.0", "44a82f82b94eeb4ba6092c89b8a6730ca1a3291c7940739d5acc8806d25ac991", [:mix], [{:bunt, "~> 0.2.0", [hex: :bunt, optional: false]}]}, - "earmark": {:hex, :earmark, "1.1.0", "8c2bf85d725050a92042bc1edf362621004d43ca6241c756f39612084e95487f", [:mix], []}, - "ex_doc": {:hex, :ex_doc, "0.14.5", "c0433c8117e948404d93ca69411dd575ec6be39b47802e81ca8d91017a0cf83c", [:mix], [{:earmark, "~> 1.0", [hex: :earmark, optional: false]}]}} +%{ + "bunt": {:hex, :bunt, "0.2.0", "951c6e801e8b1d2cbe58ebbd3e616a869061ddadcc4863d0a2182541acae9a38", [:mix], [], "hexpm", "7af5c7e09fe1d40f76c8e4f9dd2be7cebd83909f31fee7cd0e9eadc567da8353"}, + "credo": {:hex, :credo, "1.5.6", "e04cc0fdc236fefbb578e0c04bd01a471081616e741d386909e527ac146016c6", [:mix], [{:bunt, "~> 0.2.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2.8", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "4b52a3e558bd64e30de62a648518a5ea2b6e3e5d2b164ef5296244753fc7eb17"}, + "earmark": {:hex, :earmark, "1.1.0", "8c2bf85d725050a92042bc1edf362621004d43ca6241c756f39612084e95487f", [:mix], [], "hexpm", "15e3a816bdc53d12f258ea59d0c1fae9a37da2e70a0cb486edad687f65a36f66"}, + "ex_doc": {:hex, :ex_doc, "0.14.5", "c0433c8117e948404d93ca69411dd575ec6be39b47802e81ca8d91017a0cf83c", [:mix], [{:earmark, "~> 1.0", [hex: :earmark, repo: "hexpm", optional: false]}], "hexpm", "5c30e436a5acfdc2fd8fe6866585fcaf30f434c611d8119d4f3390ced2a550f3"}, + "file_system": {:hex, :file_system, "0.2.10", "fb082005a9cd1711c05b5248710f8826b02d7d1784e7c3451f9c1231d4fc162d", [:mix], [], "hexpm", "41195edbfb562a593726eda3b3e8b103a309b733ad25f3d642ba49696bf715dc"}, + "jason": {:hex, :jason, "1.2.2", "ba43e3f2709fd1aa1dce90aaabfd039d000469c05c56f0b8e31978e03fa39052", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "18a228f5f0058ee183f29f9eae0805c6e59d61c3b006760668d8d18ff0d12179"}, +} From 261cf882515725b238be9bcac9c5ac7dad03f1d7 Mon Sep 17 00:00:00 2001 From: Magnus Ottenklinger Date: Wed, 14 Jul 2021 16:26:33 +0200 Subject: [PATCH 2/3] Bump ex_doc to ~>0.24 --- mix.exs | 2 +- mix.lock | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/mix.exs b/mix.exs index c5e3afc..57e5ff3 100644 --- a/mix.exs +++ b/mix.exs @@ -26,6 +26,6 @@ defmodule LoggerFileBackend.Mixfile do defp deps do [{:credo, "~> 1.0", only: [:dev, :test]}, - {:ex_doc, ">= 0.0.0", only: :dev}] + {:ex_doc, "~> 0.24", only: :dev}] end end diff --git a/mix.lock b/mix.lock index a87dfe5..7dfa3e5 100644 --- a/mix.lock +++ b/mix.lock @@ -2,7 +2,12 @@ "bunt": {:hex, :bunt, "0.2.0", "951c6e801e8b1d2cbe58ebbd3e616a869061ddadcc4863d0a2182541acae9a38", [:mix], [], "hexpm", "7af5c7e09fe1d40f76c8e4f9dd2be7cebd83909f31fee7cd0e9eadc567da8353"}, "credo": {:hex, :credo, "1.5.6", "e04cc0fdc236fefbb578e0c04bd01a471081616e741d386909e527ac146016c6", [:mix], [{:bunt, "~> 0.2.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2.8", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "4b52a3e558bd64e30de62a648518a5ea2b6e3e5d2b164ef5296244753fc7eb17"}, "earmark": {:hex, :earmark, "1.1.0", "8c2bf85d725050a92042bc1edf362621004d43ca6241c756f39612084e95487f", [:mix], [], "hexpm", "15e3a816bdc53d12f258ea59d0c1fae9a37da2e70a0cb486edad687f65a36f66"}, - "ex_doc": {:hex, :ex_doc, "0.14.5", "c0433c8117e948404d93ca69411dd575ec6be39b47802e81ca8d91017a0cf83c", [:mix], [{:earmark, "~> 1.0", [hex: :earmark, repo: "hexpm", optional: false]}], "hexpm", "5c30e436a5acfdc2fd8fe6866585fcaf30f434c611d8119d4f3390ced2a550f3"}, + "earmark_parser": {:hex, :earmark_parser, "1.4.13", "0c98163e7d04a15feb62000e1a891489feb29f3d10cb57d4f845c405852bbef8", [:mix], [], "hexpm", "d602c26af3a0af43d2f2645613f65841657ad6efc9f0e361c3b6c06b578214ba"}, + "ex_doc": {:hex, :ex_doc, "0.24.2", "e4c26603830c1a2286dae45f4412a4d1980e1e89dc779fcd0181ed1d5a05c8d9", [:mix], [{:earmark_parser, "~> 1.4.0", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_elixir, "~> 0.14", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1", [hex: :makeup_erlang, repo: "hexpm", optional: false]}], "hexpm", "e134e1d9e821b8d9e4244687fb2ace58d479b67b282de5158333b0d57c6fb7da"}, "file_system": {:hex, :file_system, "0.2.10", "fb082005a9cd1711c05b5248710f8826b02d7d1784e7c3451f9c1231d4fc162d", [:mix], [], "hexpm", "41195edbfb562a593726eda3b3e8b103a309b733ad25f3d642ba49696bf715dc"}, "jason": {:hex, :jason, "1.2.2", "ba43e3f2709fd1aa1dce90aaabfd039d000469c05c56f0b8e31978e03fa39052", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "18a228f5f0058ee183f29f9eae0805c6e59d61c3b006760668d8d18ff0d12179"}, + "makeup": {:hex, :makeup, "1.0.5", "d5a830bc42c9800ce07dd97fa94669dfb93d3bf5fcf6ea7a0c67b2e0e4a7f26c", [:mix], [{:nimble_parsec, "~> 0.5 or ~> 1.0", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "cfa158c02d3f5c0c665d0af11512fed3fba0144cf1aadee0f2ce17747fba2ca9"}, + "makeup_elixir": {:hex, :makeup_elixir, "0.15.1", "b5888c880d17d1cc3e598f05cdb5b5a91b7b17ac4eaf5f297cb697663a1094dd", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}, {:nimble_parsec, "~> 1.1", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "db68c173234b07ab2a07f645a5acdc117b9f99d69ebf521821d89690ae6c6ec8"}, + "makeup_erlang": {:hex, :makeup_erlang, "0.1.1", "3fcb7f09eb9d98dc4d208f49cc955a34218fc41ff6b84df7c75b3e6e533cc65f", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}], "hexpm", "174d0809e98a4ef0b3309256cbf97101c6ec01c4ab0b23e926a9e17df2077cbb"}, + "nimble_parsec": {:hex, :nimble_parsec, "1.1.0", "3a6fca1550363552e54c216debb6a9e95bd8d32348938e13de5eda962c0d7f89", [:mix], [], "hexpm", "08eb32d66b706e913ff748f11694b17981c0b04a33ef470e33e11b3d3ac8f54b"}, } From 2f88e9e7ced3af4845e4a7130ceeb45788fc904b Mon Sep 17 00:00:00 2001 From: Magnus Ottenklinger Date: Wed, 14 Jul 2021 16:32:01 +0200 Subject: [PATCH 3/3] Fix small credo complaints This fixes three complaints issued by `mix credo`: * Use `_` in long numbers * Ensure whitespace after `,` * Use either `@moduledoc false`, or write a little bit of documentation --- lib/logger_file_backend.ex | 5 +++-- test/logger_file_backend_test.exs | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/logger_file_backend.ex b/lib/logger_file_backend.ex index 8831ece..07b45c9 100644 --- a/lib/logger_file_backend.ex +++ b/lib/logger_file_backend.ex @@ -1,5 +1,6 @@ defmodule LoggerFileBackend do - @moduledoc""" + @moduledoc """ + Custom `:logger` backend. """ @behaviour :gen_event @@ -191,7 +192,7 @@ defmodule LoggerFileBackend do @spec prune(IO.chardata) :: IO.chardata def prune(binary) when is_binary(binary), do: prune_binary(binary, "") - def prune([h|t]) when h in 0..1114111, do: [h|prune(t)] + def prune([h|t]) when h in 0..1_114_111, do: [h|prune(t)] def prune([h|t]), do: [prune(h)|prune(t)] def prune([]), do: [] def prune(_), do: @replacement diff --git a/test/logger_file_backend_test.exs b/test/logger_file_backend_test.exs index b66a958..bc58dd7 100644 --- a/test/logger_file_backend_test.exs +++ b/test/logger_file_backend_test.exs @@ -208,7 +208,7 @@ defmodule LoggerFileBackendTest do has_open(:os.type, path) end - defp has_open({:unix,_}, path) do + defp has_open({:unix, _}, path) do case System.cmd("lsof", [path]) do {output, 0} -> output =~ System.get_pid