Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests. #538

Open
6 of 14 tasks
fukatani opened this issue Sep 27, 2019 · 1 comment
Open
6 of 14 tasks

Add tests. #538

fukatani opened this issue Sep 27, 2019 · 1 comment
Labels
enhancement

Comments

@fukatani
Copy link
Contributor

fukatani commented Sep 27, 2019 •
edited by kmyk
Loading

I investigated code which has especially low coverage.
(from https://coveralls.io/builds/25971809 )

These are also not covered, but it seems difficult to test

  • login_with_browser
  • FormSender
  • DummySubmission
  • hackerrank.py and other contests: _get_lang_display_mapping and get_available_languages

I know this report is not perfect, your suggentions are welcome.
@fukatani
Copy link
Contributor Author

I recommend make one PR for one untested item.

fukatani added a commit to fukatani/online-judge-tools that referenced this issue Oct 1, 2019
@fukatani
online-judge-tools#538: Add float compare test.
87c6734
@fukatani fukatani mentioned this issue Oct 1, 2019
Merged
kmyk added a commit that referenced this issue Oct 1, 2019
@kmyk
Merge pull request #540 from fukatani/issue/438/float
567e89c 
#538: Add float compare test.
fukatani added a commit to fukatani/online-judge-tools that referenced this issue Oct 16, 2019
@fukatani
online-judge-tools#538: For test coverage.
0012db4
fukatani added a commit to fukatani/online-judge-tools that referenced this issue Oct 19, 2019
@fukatani
online-judge-tools#538: Test codeforces.list_problems
d9a39f9
kmyk added a commit that referenced this issue Oct 20, 2019
@kmyk
Merge pull request #560 from fukatani/issue/538/list_problems
82ee3bf 
#538: Test codeforces.list_problems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koba-e964 @fukatani