Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MustPassRepeatedly(int) to asyncAssertion #619

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Conversation

lahabana
Copy link
Contributor

Fix #618

Signed-off-by: Charly Molter charly.molter@konghq.com

Fix onsi#618

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@onsi
Copy link
Owner

onsi commented Jan 16, 2023

hey @lahabana this looks great to me! would you be up for adding some documentation to docs/index.md? I think a new subsection under the Making Asynchronous Assertions section could work. Or you might be able to just add a paragraph or so to the Eventually section.

@lahabana
Copy link
Contributor Author

@onsi done!

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@onsi
Copy link
Owner

onsi commented Jan 17, 2023

great, thanks!

@onsi onsi merged commit 4509f72 into onsi:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option in Eventually for requiring multiple successes before Accepting
2 participants