Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dlopen with FFI.verify #12

Merged
merged 6 commits into from
Jul 26, 2015
Merged

Replace dlopen with FFI.verify #12

merged 6 commits into from
Jul 26, 2015

Conversation

opalmer
Copy link
Owner

@opalmer opalmer commented Jul 26, 2015

Unfortunately, dlopen does not always work which means we have to use FFI.verify instead. The Windows function GetNamedPipeHandleState for example ends up not being found in kernel32.dll. While this might be fixable, there are other reasons for moving away from dlopen:

  • More consistent behavior across different Windows versions
  • There's no longer a need to hard code constants in the Python source
  • If we have to do something in C the background work necessary to allow this will already be complete
  • Compile time warnings, such as mismatched types in input arguments, are more obvious

@opalmer opalmer self-assigned this Jul 26, 2015
@opalmer opalmer added this to the 0.1.0 milestone Jul 26, 2015
@opalmer opalmer changed the title Replace dlopen Replace dlopen with FFI.verify Jul 26, 2015
opalmer added a commit that referenced this pull request Jul 26, 2015
Replace dlopen with FFI.verify
@opalmer opalmer merged commit 9850cf6 into master Jul 26, 2015
@opalmer opalmer deleted the replace_dlopen branch July 28, 2015 02:29
@opalmer opalmer added the core label Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant