Release Tools Had Wrong URLs and Broken Tests #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces most of the mocks with a simplified setup. This is more readable and easiear to control. It would still be better to not use mocks but testing against GitHub's API is unfair to GitHub and it's also would not keep tests separated from the repository.
opalmer
changed the title
Current coverage is
|
opalmer
added a commit
that referenced
this pull request
Jan 18, 2016
Release Tools Had Wrong URLs and Broken Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bugs in
dev.releasewhich were discovered when releasing 0.1.1. It also tries to cleanup the tests so they're more readable and reliable.